Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Redesign/refactor next recommended action #14032

Merged
merged 30 commits into from
Nov 18, 2024
Merged

refactor: Redesign/refactor next recommended action #14032

merged 30 commits into from
Nov 18, 2024

Conversation

lassopicasso
Copy link
Contributor

@lassopicasso lassopicasso commented Nov 11, 2024 •
edited
Loading

Description

This PR updates the user story for component "Tabell for underskjema" based on the latest Figma design for subform and discussions with Anniken.

Design changes:

  • Remove the close button below the selector; users must select or create a subform before proceeding.
  • Disable autosave when selecting a subform; users must click "Save" to confirm, as re-selection is disabled.
  • Restrict relink subform in "Tabell for underskjema" when a subform is already linked.
  • When "Create new subform" is clicked, replace the selector with a card containing input-elements, save and slose buttons.
  • Keep the user in the current configuration view after creating a new subform (no redirect).
  • Replace the warning message with a recommended action card, including instructions and a create-subform card, if no subform layout sets are available.
  • Rename the "til utforming" button to "Utform underskjemaet."
  • Add an "Utform underskjemaet" button in the open config area below the linked subform.

Code changes:

  • Refactor code to support design adjustments.
  • Remove outdated text keys for older subform designs.
  • Reorganize to be closer to their respective code files and update/remove tests.
Video: Old User Story
gammel-brukerreise-underskjema.mp4
Video: New User Story
ny-brukerreise-underskjema.mp4

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Nov 11, 2024
@lassopicasso lassopicasso linked an issue Nov 11, 2024 that may be closed by this pull request
adjust the implementations of Next Recommended Action for Tabell for underskjema #13999
Closed
@lassopicasso lassopicasso changed the title Redesign/refactor next recommended action refactor: Redesign/refactor next recommended action Nov 12, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.30%. Comparing base (4d8c7e3) to head (21d4c71).
Report is 9 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14032      +/-   ##
==========================================
+ Coverage   95.28%   95.30%   +0.02%     
==========================================
  Files        1763     1762       -1     
  Lines       23000    23005       +5     
  Branches     2676     2677       +1     
==========================================
+ Hits        21915    21926      +11     
+ Misses        836      832       -4     
+ Partials      249      247       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lassopicasso lassopicasso marked this pull request as ready for review November 14, 2024 11:20
@lassopicasso lassopicasso requested a review from Jondyr November 14, 2024 11:20
Jondyr
Jondyr approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@Jondyr Jondyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring/cleanup of tests👍

...studio-components/src/components/StudioRecommendedNextAction/StudioRecommendedNextAction.tsx Show resolved Hide resolved
@github-actions github-actions bot added the quality/testing Tests that are missing, needs to be created or could be improved. label Nov 15, 2024
JamalAlabdullah
JamalAlabdullah approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ok and works as expected

@JamalAlabdullah JamalAlabdullah merged commit 1f8e40d into main Nov 18, 2024
17 checks passed
@JamalAlabdullah JamalAlabdullah deleted the redesign/refactor-next-recommended-action branch November 18, 2024 11:51
nkylstad pushed a commit that referenced this pull request Nov 26, 2024
@lassopicasso @nkylstad
refactor: Redesign/refactor next recommended action (#14032)
c50fd23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamalAlabdullah JamalAlabdullah JamalAlabdullah approved these changes

@Jondyr Jondyr Jondyr approved these changes

Assignees
No one assigned
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend quality/testing Tests that are missing, needs to be created or could be improved. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adjust the implementations of Next Recommended Action for Tabell for underskjema
3 participants
@lassopicasso @Jondyr @JamalAlabdullah